[all-commits] [llvm/llvm-project] f5f4b8: [AMDGPU][MC] Restore old error position for "too f...

Scott Linder via All-commits all-commits at lists.llvm.org
Wed Dec 9 13:10:23 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f5f4b8b60fc0931440c4f2549fbff0965c868d2c
      https://github.com/llvm/llvm-project/commit/f5f4b8b60fc0931440c4f2549fbff0965c868d2c
  Author: Scott Linder <Scott.Linder at amd.com>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
    M llvm/test/MC/AMDGPU/exp-err.s
    M llvm/test/MC/AMDGPU/gfx10_err_pos.s

  Log Message:
  -----------
  [AMDGPU][MC] Restore old error position for "too few operands"

Revert part of https://reviews.llvm.org/D92084 to make it simpler to
start consuming the EndOfStatement token within AMDGPU's
ParseInstruction in a future patch. This also brings us back to what
every other target currently does.

A future change to move the position back to the end of the statement
would likely need to audit all of the AMDGPUOperand SMLoc ranges, and
determine the SMLoc for the last character of the last operand.

Reviewed By: dp

Differential Revision: https://reviews.llvm.org/D92960




More information about the All-commits mailing list