[all-commits] [llvm/llvm-project] a21e60: [X86] Add broadcast merge test case for PR48215

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Wed Dec 9 08:31:02 PST 2020


  Branch: refs/heads/release/11.x
  Home:   https://github.com/llvm/llvm-project
  Commit: a21e609d6a255f893fa7cbd863a3bc5c017c478e
      https://github.com/llvm/llvm-project/commit/a21e609d6a255f893fa7cbd863a3bc5c017c478e
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    A llvm/test/CodeGen/X86/pr48215.ll

  Log Message:
  -----------
  [X86] Add broadcast merge test case for PR48215

(cherry picked from commit 8270f8c252d7013761c54e5bf528ac3e4e3b517c)
Signed-off-by: Warren Ristow <warren.ristow at sony.com>


  Commit: 14d60e9a80d40f9efc4b76524a07320d38994d2b
      https://github.com/llvm/llvm-project/commit/14d60e9a80d40f9efc4b76524a07320d38994d2b
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-12-09 (Wed, 09 Dec 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/test/CodeGen/X86/pr48215.ll

  Log Message:
  -----------
  [X86][AVX] Only share broadcasts of different widths from the same SDValue of the same SDNode (PR48215)

D57663 allowed us to reuse broadcasts of the same scalar value by extracting low subvectors from the widest type.

Unfortunately we weren't ensuring the broadcasts were from the same SDValue, just the same SDNode - which failed on multiple-value nodes like ISD::SDIVREM

FYI: I intend to request this be merged into the 11.x release branch.

Differential Revision: https://reviews.llvm.org/D91709

(cherry picked from commit 14ae02fb3397961bb5f99a0df60622375fc1976d)
Signed-off-by: Warren Ristow <warren.ristow at sony.com>


Compare: https://github.com/llvm/llvm-project/compare/0feb4bc5295b...14d60e9a80d4


More information about the All-commits mailing list