[all-commits] [llvm/llvm-project] 25f5df: SemaType.cpp - use castAs<> instead of getAs<> for...

[Christian Sigg via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 25f5df7e0bc950ad244e8da000ce4248bd41c140
      https://github.com/llvm/llvm-project/commit/25f5df7e0bc950ad244e8da000ce4248bd41c140
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
    M clang/lib/Sema/SemaType.cpp

  Log Message:
  -----------
  SemaType.cpp - use castAs<> instead of getAs<> for dereferenced pointers

Fix static analyzer warnings - castAs<> will assert the type is correct, but getAs<> just returns null, which would just result in a dereferenced null pointer.


  Commit: 2a9840900ccc0add8fc6aed0533ceec198b3514d
      https://github.com/llvm/llvm-project/commit/2a9840900ccc0add8fc6aed0533ceec198b3514d
  Author: Christian Sigg <csigg at google.com>
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
    M mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
    M mlir/include/mlir/IR/PatternMatch.h
    M mlir/include/mlir/Transforms/DialectConversion.h

  Log Message:
  -----------
  [mlir] Revert "Tighten access of RewritePattern methods."

This reverts commit 02c9050155dff70497b3423ae95ed7d2ab7675a8.
Painted myself into a corner with -Wvirtual_overload, private access, and final.

Differential Revision: https://reviews.llvm.org/D92855


Compare: https://github.com/llvm/llvm-project/compare/111ae220a3bf...2a9840900ccc