[all-commits] [llvm/llvm-project] a13447: Revert "Add new 'preferred_name' attribute."

[Richard Smith via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a1344779ab019a6bcd29842c1499343e15efbe87
      https://github.com/llvm/llvm-project/commit/a1344779ab019a6bcd29842c1499343e15efbe87
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
    M clang/include/clang/AST/TypeProperties.td
    M clang/include/clang/Basic/Attr.td
    M clang/include/clang/Basic/AttrDocs.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/lib/AST/TypePrinter.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    M clang/lib/Sema/SemaTemplate.cpp
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
    R clang/test/PCH/decl-attrs.cpp
    M clang/test/SemaTemplate/attributes.cpp
    M clang/utils/TableGen/ClangAttrEmitter.cpp
    M libcxx/include/__config
    M libcxx/include/iosfwd
    M libcxx/include/regex
    M libcxx/include/string
    M libcxx/include/string_view

  Log Message:
  -----------
  Revert "Add new 'preferred_name' attribute."

This change exposed a pre-existing issue with deserialization cycles
caused by a combination of attributes and template instantiations
violating the deserialization ordering restrictions; see PR48434 for
details.

A previous commit attempted to work around PR48434, but appears to have
only been a partial fix, and fixing this properly seems non-trivial.
Backing out for now to unblock things.

This reverts commit 98f76adf4e941738c0b9fe3b9965fa63603e9c89 and
commit a64c26a47a81b1b44e36d235ff3bc6a74a0bad9f.