[all-commits] [llvm/llvm-project] 441567: Fix shtest-timeout test harder

David Blaikie via All-commits all-commits at lists.llvm.org
Tue Dec 8 00:24:00 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4415678718ad471c84f024e20ce864ae1e79348a
      https://github.com/llvm/llvm-project/commit/4415678718ad471c84f024e20ce864ae1e79348a
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2020-12-08 (Tue, 08 Dec 2020)

  Changed paths:
    M llvm/utils/lit/tests/Inputs/shtest-timeout/infinite_loop.py
    M llvm/utils/lit/tests/shtest-timeout.py

  Log Message:
  -----------
  Fix shtest-timeout test harder

Don't produce or expect any output from the infinite looping test -
doing so is a recipe for racey flakyness without a longer timeout to
ensure the output is received first, even though that doesn't seem
integral/important to the test. Instead have a plain, no output infinite
loop and check that that is caught and handled.

If for some reason the output is valuable for test coverage - the
timeout should be increased from 1 second to give the process time to
output the text, flush, and for that text to be received and buffered
before the test is timed out.




More information about the All-commits mailing list