[all-commits] [llvm/llvm-project] ccc516: Fixup test in path to use C:\ instead of D:\ which...

dyung via All-commits all-commits at lists.llvm.org
Mon Dec 7 16:44:15 PST 2020


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ccc5160df100663630329e2e544fc04dd126f88f
      https://github.com/llvm/llvm-project/commit/ccc5160df100663630329e2e544fc04dd126f88f
  Author: Douglas Yung <douglas.yung at sony.com>
  Date:   2020-12-07 (Mon, 07 Dec 2020)

  Changed paths:
    M llvm/test/tools/llvm-symbolizer/pdb/Inputs/missing_pdb.exe

  Log Message:
  -----------
  Fixup test in path to use C:\ instead of D:\ which may be mapped to a removable.

Our internal build bot hit a failure in llvm/test/tools/llvm-symbolizer/pdb/missing_pdb.test
because the test was checking for an error message that is emitted when a pdb file is
missing. But when the drive is mapped to a removalable drive (such as a DVD drive) in
Windows, you get a different error message which causes the test to fail.

This fixes the test by changing the drive the missing pdb is expected to be on to C:\
instead of D:\ as that is the drive historically used to install Windows and thus
if present should be a hard drive.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D92787




More information about the All-commits mailing list