[all-commits] [llvm/llvm-project] 266c90: [lldb] [test] Link FreeBSD test failures to bugs

Mon Dec 7 01:02:10 PST 2020

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 266c90fec899356aa2c88f1e614d40d554db6fb3
      https://github.com/llvm/llvm-project/commit/266c90fec899356aa2c88f1e614d40d554db6fb3
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-12-07 (Mon, 07 Dec 2020)

  Changed paths:
    M lldb/test/API/api/multithreaded/TestMultithreaded.py
    M lldb/test/API/commands/expression/multiline-navigation/TestMultilineNavigation.py
    M lldb/test/API/commands/process/launch-with-shellexpand/TestLaunchWithShellExpand.py
    M lldb/test/API/commands/register/register/register_command/TestRegisters.py
    M lldb/test/API/commands/target/create-deps/TestTargetCreateDeps.py
    M lldb/test/API/functionalities/breakpoint/breakpoint_callback_command_source/TestBreakpointCallbackCommandSource.py
    M lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
    M lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py
    M lldb/test/API/functionalities/dlopen_other_executable/TestDlopenOtherExecutable.py
    M lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py
    M lldb/test/API/functionalities/return-value/TestReturnValue.py
    M lldb/test/API/functionalities/thread/create_after_attach/TestCreateAfterAttach.py
    M lldb/test/API/functionalities/thread/exit_during_expression/TestExitDuringExpression.py
    M lldb/test/API/functionalities/thread/state_after_expression/TestStateAfterExpression.py
    M lldb/test/API/lang/c/conflicting-symbol/TestConflictingSymbol.py
    M lldb/test/API/python_api/event/TestEvents.py
    M lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
    M lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
    M lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py
    M lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_setBreakpoints.py
    M lldb/test/API/tools/lldb-vscode/launch/TestVSCode_launch.py

  Log Message:
  -----------
  [lldb] [test] Link FreeBSD test failures to bugs

Differential Revision: https://reviews.llvm.org/D92740

  Commit: 1a1cc0ba7db549025ab1a504633ae4554042fd60
      https://github.com/llvm/llvm-project/commit/1a1cc0ba7db549025ab1a504633ae4554042fd60
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-12-07 (Mon, 07 Dec 2020)

  Changed paths:
    M lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
    M lldb/test/API/commands/process/attach-resume/TestAttachResume.py
    M lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py

  Log Message:
  -----------
  [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

Force gdb-remote plugin when attaching using the derivatives
of PlatformPOSIX class.  This is consistent with the behavior
for launching processes (via DebugProcess() method) and guarantees
consistent plugin choice on FreeBSD.

Differential Revision: https://reviews.llvm.org/D92667

  Commit: 09b08833f301ea375137931d26b7193101f82ceb
      https://github.com/llvm/llvm-project/commit/09b08833f301ea375137931d26b7193101f82ceb
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-12-07 (Mon, 07 Dec 2020)

  Changed paths:
    M lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp
    M lldb/test/API/api/multithreaded/TestMultithreaded.py
    M lldb/test/API/functionalities/breakpoint/global_constructor/TestBreakpointInGlobalConstructor.py
    M lldb/test/API/functionalities/memory-region/TestMemoryRegion.py
    M lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
    M lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
    M lldb/test/Shell/Unwind/thread-step-out-ret-addr-check.test

  Log Message:
  -----------
  [lldb] [POSIX-DYLD] Add libraries from initial eTakeSnapshot action

Explicitly consider the libraries reported on the initial eTakeSnapshot
action added, through adding them to the added soentry list
in DYLDRendezvous::SaveSOEntriesFromRemote().  This is necessary
on FreeBSD since the dynamic loader issues only a single 'consistent'
state rendezvous breakpoint hit for all the libraries present
in DT_NEEDED (while Linux issues an added-consistent event pair).

Reenable memory maps on FreeBSD since this fixed the issue triggered
by them.

Differential Revision: https://reviews.llvm.org/D92187

  Commit: 276638ecaf226a9931c55e835f18b592bdfbea86
      https://github.com/llvm/llvm-project/commit/276638ecaf226a9931c55e835f18b592bdfbea86
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-12-07 (Mon, 07 Dec 2020)

  Changed paths:
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.h

  Log Message:
  -----------
  [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

Copy the Linux implementation of GetLoadedModuleFileSpec()
and GetFileLoadAddress() into NativeProcessFreeBSD.  This does not seem
to change anything at the moment but reducing the differences between
the plugins should help us in the long term.

Differential Revision: https://reviews.llvm.org/D92314

  Commit: 77f0ea4b5b978c7caa0788ae8b1a2429089021bd
      https://github.com/llvm/llvm-project/commit/77f0ea4b5b978c7caa0788ae8b1a2429089021bd
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-12-07 (Mon, 07 Dec 2020)

  Changed paths:
    M lldb/test/API/functionalities/thread/step_out/TestThreadStepOut.py

  Log Message:
  -----------
  [lldb] [test] Fix continue_to_breakpoint() args in TestThreadStepOut

The test is skipped/xfailing on all platforms, so it seems that the API
got out of sync.  Fix that so it returns to a 'proper' failure
on FreeBSD.

Differential Revision: https://reviews.llvm.org/D92746

Compare: https://github.com/llvm/llvm-project/compare/53401e8e8864...77f0ea4b5b97