[all-commits] [llvm/llvm-project] fe7fdc: [MLIR] Fix parseFunctionLikeOp() to fail parsing e...

[Rahul Joshi via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fe7fdcac87be4ad3de34901eb6fb5746437610e8
      https://github.com/llvm/llvm-project/commit/fe7fdcac87be4ad3de34901eb6fb5746437610e8
  Author: Rahul Joshi <jurahul at google.com>
  Date:   2020-12-04 (Fri, 04 Dec 2020)

  Changed paths:
    M flang/include/flang/Optimizer/Dialect/FIROps.td
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
    M mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
    M mlir/lib/IR/FunctionImplementation.cpp
    M mlir/lib/Parser/Parser.cpp
    M mlir/test/Dialect/SCF/canonicalize.mlir
    M mlir/test/IR/invalid.mlir
    M mlir/test/IR/traits.mlir
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions

- Change parseOptionalRegion to return an OptionalParseResult.
- Change parseFunctionLikeOp() to fail parsing if the function body was parsed but was
  empty.
- See https://llvm.discourse.group/t/funcop-parsing-bug/2164

Differential Revision: https://reviews.llvm.org/D91886