[all-commits] [llvm/llvm-project] 3df0da: [IndVars] Quick fix LHS/RHS bug

[max-azul via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3df0daceb2c684c8bd704595e70c08500bb051ed
      https://github.com/llvm/llvm-project/commit/3df0daceb2c684c8bd704595e70c08500bb051ed
  Author: Max Kazantsev <mkazantsev at azul.com>
  Date:   2020-12-04 (Fri, 04 Dec 2020)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyIndVar.cpp

  Log Message:
  -----------
  [IndVars] Quick fix LHS/RHS bug

The code relies on fact that LHS is the NarrowDef but never
really checks it. Adding the conservative restrictive check,
will follow-up with handling of case where RHS is a NarrowDef.


  Commit: 12b6c5e68282be7beac597300cf90a9d6ae3e1dd
      https://github.com/llvm/llvm-project/commit/12b6c5e68282be7beac597300cf90a9d6ae3e1dd
  Author: Max Kazantsev <mkazantsev at azul.com>
  Date:   2020-12-04 (Fri, 04 Dec 2020)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyIndVar.cpp
    M llvm/test/Transforms/IndVarSimplify/widen-loop-comp.ll

  Log Message:
  -----------
  Return "[IndVars] ICmpInst should not prevent IV widening"

This reverts commit 4bd35cdc3ae1874c6d070c5d410b3f591de54ee6.

The patch was reverted during the investigation. The investigation
shown that the patch did not cause any trouble, but just exposed
the existing problem that is addressed by the previous patch
"[IndVars] Quick fix LHS/RHS bug". Returning without changes.


Compare: https://github.com/llvm/llvm-project/compare/dec1bbb47cda...12b6c5e68282