[all-commits] [llvm/llvm-project] e61a6a: Bump MSVC required version to 19.14

Reid Kleckner via All-commits all-commits at lists.llvm.org
Thu Dec 3 10:10:02 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e61a6a229a992d291da81ab96299669e8d28d6ad
      https://github.com/llvm/llvm-project/commit/e61a6a229a992d291da81ab96299669e8d28d6ad
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-12-03 (Thu, 03 Dec 2020)

  Changed paths:
    M llvm/cmake/modules/CheckCompilerVersion.cmake

  Log Message:
  -----------
  Bump MSVC required version to 19.14

LLVM passes overaligned objects by value, which MSVC 19.1 didn't support on
x86_32. MSVC added this support somewhere between 19.1 and 19.14, but godbolt
doesn't have 19.11, 19.12, or 19.13 so I can't test before 19.14:
https://gcc.godbolt.org/z/75YoEz

Even if users are using the Visual Studio 2017 series of Visual C++ toolchains,
they should've already updated to 19.14 or newer at this point, or they
wouldn't be able to build LLVM. This just raises the CMake required minimum
version so the build fails earlier.

Differential Revision: https://reviews.llvm.org/D92515




More information about the All-commits mailing list