[all-commits] [llvm/llvm-project] dd2054: [lldb] Treat remote macOS debugging like any other...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd2054d38a848a75fe84fb68d9c3a97e5ade6753
      https://github.com/llvm/llvm-project/commit/dd2054d38a848a75fe84fb68d9c3a97e5ade6753
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-12-02 (Wed, 02 Dec 2020)

  Changed paths:
    M lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt
    M lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
    A lldb/source/Plugins/Platform/MacOSX/PlatformRemoteMacOSX.cpp
    A lldb/source/Plugins/Platform/MacOSX/PlatformRemoteMacOSX.h
    A lldb/test/API/commands/platform/sdk/Makefile
    A lldb/test/API/commands/platform/sdk/TestPlatformSDK.py
    A lldb/test/API/commands/platform/sdk/main.c
    M lldb/unittests/Process/ProcessEventDataTest.cpp

  Log Message:
  -----------
  [lldb] Treat remote macOS debugging like any other remote darwin platform

Extract remote debugging logic from PlatformMacOSX and move it into
PlatformRemoteMacOSX so it can benefit from all the logic necessary for
remote debugging.

Until now, remote macOS debugging was treated almost identical to local
macOS debugging. By moving in into its own class, we can have it inherit
from PlatformRemoteDarwinDevice and all the functionality it provides,
such as looking at the correct DeviceSupport directory.

rdar://68167374

Differential revision: https://reviews.llvm.org/D92452