[all-commits] [llvm/llvm-project] 874810: [llvm-readelf] - Switch to using from `reportWarni...
Georgii Rymar via All-commits
all-commits at lists.llvm.org
Tue Dec 1 00:10:15 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 87481068fddf29e913b129b9c962ba761ae478c8
https://github.com/llvm/llvm-project/commit/87481068fddf29e913b129b9c962ba761ae478c8
Author: Georgii Rymar <grimar at accesssoftek.com>
Date: 2020-12-01 (Tue, 01 Dec 2020)
Changed paths:
M llvm/tools/llvm-readobj/ELFDumper.cpp
Log Message:
-----------
[llvm-readelf] - Switch to using from `reportWarning` to `reportUniqueWarning` in `DynRegionInfo`.
This is a part of the plan we had previously to convert all calls to
`reportUniqueWarning` and then rename it to just `reportWarning`.
I was a bit unsure about this particular change at first, because it doesn't add a
new functionality: seems it is impossible to trigger a warning duplication currently.
At the same time I find the idea of the plan mentioned very reasonable.
And with that we will be sure that `DynRegionInfo` can't report duplicate
warnings, what looks like a nice feature for possible refactorings and further tool development.
Differential revision: https://reviews.llvm.org/D92224
More information about the All-commits
mailing list