[all-commits] [llvm/llvm-project] 774f1d: [mlir] Small cleanups to func-bufferize/finalizing...

Sean Silva via All-commits all-commits at lists.llvm.org
Mon Nov 30 17:10:01 PST 2020


  Branch: refs/heads/temp-test-main
  Home:   https://github.com/llvm/llvm-project
  Commit: 774f1d3ffd458d6cb82d5039758ef1cf6370957f
      https://github.com/llvm/llvm-project/commit/774f1d3ffd458d6cb82d5039758ef1cf6370957f
  Author: Sean Silva <silvasean at google.com>
  Date:   2020-11-30 (Mon, 30 Nov 2020)

  Changed paths:
    M mlir/lib/Dialect/SCF/Transforms/Bufferize.cpp
    M mlir/lib/Dialect/StandardOps/Transforms/Bufferize.cpp
    M mlir/lib/Transforms/Bufferize.cpp
    M mlir/test/Dialect/Standard/bufferize.mlir
    R mlir/test/Dialect/Standard/func-bufferize-partial.mlir
    M mlir/test/Dialect/Standard/func-bufferize.mlir
    A mlir/test/Transforms/finalizing-bufferize.mlir

  Log Message:
  -----------
  [mlir] Small cleanups to func-bufferize/finalizing-bufferize

- Address TODO in scf-bufferize: the argument materialization issue is
  now fixed and the code is now in Transforms/Bufferize.cpp
- Tighten up finalizing-bufferize to avoid creating invalid IR when
  operand types potentially change
- Tidy up the testing of func-bufferize, and move appropriate tests
  to a new finalizing-bufferize.mlir
- The new stricter checking in finalizing-bufferize revealed that we
  needed a DimOp conversion pattern (found when integrating into npcomp).
  Previously, the converion infrastructure was blindly changing the
  operand type during finalization, which happened to work due to
  DimOp's tensor/memref polymorphism, but is generally not encouraged
  (the new pattern is the way to tell the conversion infrastructure that
  it is legal to change that type).




More information about the All-commits mailing list