[all-commits] [llvm/llvm-project] b5af57: [WinASan] Improve exception reporting accuracy

[Reid Kleckner via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b5af5787b367198f8b87626431cb3f66fef460c1
      https://github.com/llvm/llvm-project/commit/b5af5787b367198f8b87626431cb3f66fef460c1
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-11-30 (Mon, 30 Nov 2020)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_win.cpp
    A compiler-rt/test/asan/TestCases/Windows/breakpoint.cpp
    A compiler-rt/test/asan/TestCases/Windows/illegal_instruction.cpp
    A compiler-rt/test/asan/TestCases/Windows/integer_divide_by_zero.cpp
    A compiler-rt/test/asan/TestCases/Windows/sse_misalignment.cpp

  Log Message:
  -----------
  [WinASan] Improve exception reporting accuracy

Previously, ASan would produce reports like this:
ERROR: AddressSanitizer: breakpoint on unknown address 0x000000000000 (pc 0x7fffdd7c5e86 ...)

This is unhelpful, because the developer may think this is a null
pointer dereference, and not a breakpoint exception on some PC.

The cause was that SignalContext::GetAddress would read the
ExceptionInformation array to retreive an address for any kind of
exception. That data is only available for access violation exceptions.
This changes it to be conditional on the exception type, and to use the
PC otherwise.

I added a variety of tests for common exception types:
- int div zero
- breakpoint
- ud2a / illegal instruction
- SSE misalignment

I also tightened up IsMemoryAccess and GetWriteFlag to check the
ExceptionCode rather than looking at ExceptionInformation[1] directly.

Differential Revision: https://reviews.llvm.org/D92344