[all-commits] [llvm/llvm-project] 95956c: [MLIR] ODS typedef gen fixes & improvements

John Demme via All-commits all-commits at lists.llvm.org
Sun Nov 22 16:19:41 PST 2020


  Branch: refs/heads/temp-test-main
  Home:   https://github.com/llvm/llvm-project
  Commit: 95956c1c9aae7ea21c2b2f7a21e0901d549bd190
      https://github.com/llvm/llvm-project/commit/95956c1c9aae7ea21c2b2f7a21e0901d549bd190
  Author: John Demme <john.demme at microsoft.com>
  Date:   2020-11-22 (Sun, 22 Nov 2020)

  Changed paths:
    M mlir/lib/TableGen/TypeDef.cpp
    M mlir/test/mlir-tblgen/typedefs.td
    M mlir/tools/mlir-tblgen/TypeDefGen.cpp

  Log Message:
  -----------
  [MLIR] ODS typedef gen fixes & improvements

- Fixes bug 48242 point 3 crash.
- Makes the improvments from points 1 & 2.

https://bugs.llvm.org/show_bug.cgi?id=48262

```
   def RTLValueType : Type<CPred<"isRTLValueType($_self)">, "Type"> {
     string cppType = "::mlir::Type";
   }
```
Works now, but merely by happenstance. Parameters expects a `TypeParameter` class def or a string representing a c++ type but doesn't enforce it.

Reviewed By: lattner

Differential Revision: https://reviews.llvm.org/D91939




More information about the All-commits mailing list