[all-commits] [llvm/llvm-project] 9bb5bf: [mlir] Add an assertion on creating an Operation w...

ftynse via All-commits all-commits at lists.llvm.org
Thu Nov 19 13:28:57 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9bb5bff570140d4fc5b1750ca7352b840dd58ed7
      https://github.com/llvm/llvm-project/commit/9bb5bff570140d4fc5b1750ca7352b840dd58ed7
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
    M mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
    M mlir/lib/IR/Operation.cpp
    M mlir/lib/IR/TypeRange.cpp
    M mlir/test/Conversion/StandardToLLVM/standard-to-llvm.mlir

  Log Message:
  -----------
  [mlir] Add an assertion on creating an Operation with null result types

Null types are commonly used as an error marker. Catch them in the constructor
of Operation if they are present in the result type list, as otherwise this
could lead to further surprising behavior when querying op result types.

Fix AsyncToLLVM and StandardToLLVM that were using null types when constructing
operations.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D91770




More information about the All-commits mailing list