[all-commits] [llvm/llvm-project] 734d2f: [clangd] No crash on "-verify" mode.

Haojian Wu via All-commits all-commits at lists.llvm.org
Thu Nov 19 06:52:43 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 734d2f98f64940b1f545d677729d213a954c7a3f
      https://github.com/llvm/llvm-project/commit/734d2f98f64940b1f545d677729d213a954c7a3f
  Author: Haojian Wu <hokein.wu at gmail.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M clang-tools-extra/clangd/Compiler.cpp
    M clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp

  Log Message:
  -----------
  [clangd] No crash on "-verify" mode.

If there is a "-verify" flag in the compile command, clangd will crash
(hit the assertion) inside the `~VerifyDiagnosticConsumer` (Looks like our
compiler invocation doesn't setup correctly?).

This patch disables the verify mode as it is rarely useful in clangd.

Differential Revision: https://reviews.llvm.org/D91777




More information about the All-commits mailing list