[all-commits] [llvm/llvm-project] 7bf89c: [NFC][Reassociate] Delay checking isLoadCombineCan...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Wed Nov 18 12:57:55 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7bf89c2174f0b2a91a4f680b3246d432c135381b
      https://github.com/llvm/llvm-project/commit/7bf89c2174f0b2a91a4f680b3246d432c135381b
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2020-11-18 (Wed, 18 Nov 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/Reassociate.cpp

  Log Message:
  -----------
  [NFC][Reassociate] Delay checking isLoadCombineCandidate() until after ShouldConvertOrWithNoCommonBitsToAdd() but before haveNoCommonBitsSet()

This appears to improve -O3 compile-time performance somewhat:
https://llvm-compile-time-tracker.com/compare.php?from=87369c626114ae17f4c637635c119e6de0856a9a&to=c04b8271e1609b0dfb20609b40844b0c4324517e&stat=instructions
It doesn't look like delaying it until after haveNoCommonBitsSet() is better:
https://llvm-compile-time-tracker.com/compare.php?from=c04b8271e1609b0dfb20609b40844b0c4324517e&to=b2943d450eaf41b5f76d2dc7350f0a279f64cd99&stat=instructions




More information about the All-commits mailing list