[all-commits] [llvm/llvm-project] e6aa06: [NFC, Refactor] Modernize the TypeSpecifierWidth e...

Faisal Vali via All-commits all-commits at lists.llvm.org
Sun Nov 15 09:16:59 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e6aa06545b123292be283af7c414daead23cf9ab
      https://github.com/llvm/llvm-project/commit/e6aa06545b123292be283af7c414daead23cf9ab
  Author: faisalv <faisalv at yahoo.com>
  Date:   2020-11-15 (Sun, 15 Nov 2020)

  Changed paths:
    M clang/include/clang/AST/TypeLoc.h
    M clang/include/clang/Basic/Specifiers.h
    M clang/include/clang/Sema/DeclSpec.h
    M clang/lib/Parse/ParseDecl.cpp
    M clang/lib/Parse/ParseExprCXX.cpp
    M clang/lib/Sema/DeclSpec.cpp
    M clang/lib/Sema/SemaType.cpp
    M clang/lib/Serialization/ASTReader.cpp
    M clang/lib/Serialization/ASTWriter.cpp

  Log Message:
  -----------
  [NFC, Refactor] Modernize the TypeSpecifierWidth enum (Specifiers.h) to a scoped enum

Reviewed here: https://reviews.llvm.org/D91409 by Aaron.
Highlights of the review:
  - avoid an underlying type for enums
  - avoid enum bit fields (MSVC packing anomalies) and favor static_casts to unsigned bit-fields

Patch by Thorsten Schuett <schuett at gmail.com> w some minor fixes in SemaType.cpp where a couple asserts had to be repaired to deal with lack of implicit coversion to int.

Thanks Thorsten!




More information about the All-commits mailing list