[all-commits] [llvm/llvm-project] d87fd0: Serialization: Hoist the check for in-flight diagn...

Duncan P. N. Exon Smith via All-commits all-commits at lists.llvm.org
Fri Nov 13 10:26:58 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d87fd096ac3eb27f376c0182ed5e3034ce240861
      https://github.com/llvm/llvm-project/commit/d87fd096ac3eb27f376c0182ed5e3034ce240861
  Author: Duncan P. N. Exon Smith <dexonsmith at apple.com>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M clang/include/clang/Serialization/ASTReader.h
    M clang/lib/Serialization/ASTReader.cpp

  Log Message:
  -----------
  Serialization: Hoist the check for in-flight diagnostics in ASTReader::getInputFile, NFC

This logic seems easier to follow without the `Error()` helper, and
checking `DiagnosticsEngine::isDiagnosticInFlight` just once up front.

Differential Revision: https://reviews.llvm.org/D91366




More information about the All-commits mailing list