[all-commits] [llvm/llvm-project] 105ed2: Revert "[AsmPrinter] fix -disable-debug-info option"

Hans via All-commits all-commits at lists.llvm.org
Fri Nov 13 04:51:09 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 105ed27ed80dd47a9d32e72bbdd2a776a3318f38
      https://github.com/llvm/llvm-project/commit/105ed27ed80dd47a9d32e72bbdd2a776a3318f38
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-11-13 (Fri, 13 Nov 2020)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    R llvm/test/CodeGen/Generic/disable-debug-info-print.ll

  Log Message:
  -----------
  Revert "[AsmPrinter] fix -disable-debug-info option"

The test fails on Mac, see comment on the code review.

> This option was in a rather convoluted place, causing global parameters
> to be set in awkward and undesirable ways to try to account for it
> indirectly. Add tests for the -disable-debug-info option and ensure we
> don't print unintended markers from unintended places.
>
> Reviewed By: dstenb
>
> Differential Revision: https://reviews.llvm.org/D91083

This reverts commit 9606ef03f03904cec213db031b5ea6fd6052dc5d.




More information about the All-commits mailing list