[all-commits] [llvm/llvm-project] 92b036: debugserver should advance pc past builtin_debugtr...

[Jason Molenda via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 92b036dea24b6e7ebfd950facdbf5543135eda05
      https://github.com/llvm/llvm-project/commit/92b036dea24b6e7ebfd950facdbf5543135eda05
  Author: Jason Molenda <jason at molenda.com>
  Date:   2020-11-12 (Thu, 12 Nov 2020)

  Changed paths:
    A lldb/test/API/macosx/builtin-debugtrap/Makefile
    A lldb/test/API/macosx/builtin-debugtrap/TestBuiltinDebugTrap.py
    A lldb/test/API/macosx/builtin-debugtrap/main.cpp
    M lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp

  Log Message:
  -----------
  debugserver should advance pc past builtin_debugtrap insn

On x86_64, when you hit a __builtin_debugtrap instruction, you
can continue past this in the debugger.  This patch has debugserver
recognize the specific instruction used for __builtin_debugtrap
and advance the pc past it, so that the user can continue execution
once they've hit one of these.

In the patch discussion, we were in agreement that it would be better
to have this knowledge up in lldb instead of depending on each
stub rewriting the pc behind the debugger's back, but that's a
larger scale change for another day.

<rdar://problem/65521634>
Differential revision: https://reviews.llvm.org/D91238