[all-commits] [llvm/llvm-project] b33682: Non-implicit attribute creation requires a source ...

[Aaron Ballman via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b336826c1dd92adabef682f9b013b2e36bce066c
      https://github.com/llvm/llvm-project/commit/b336826c1dd92adabef682f9b013b2e36bce066c
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2020-11-12 (Thu, 12 Nov 2020)

  Changed paths:
    M clang/include/clang/Basic/Attr.td
    M clang/utils/TableGen/ClangAttrEmitter.cpp

  Log Message:
  -----------
  Non-implicit attribute creation requires a source range; NFC

There are two factory functions used to create a semantic attribute,
Create() and CreateImplicit(). CreateImplicit() does not need to
specify the source range of the attribute since it's an implicitly-
generated attribute. The same logic does not apply to Create(), so
this removes the default argument from those declarations to avoid
accidentally creating a semantic attribute without source location
information.