[all-commits] [llvm/llvm-project] a8bfee: [lldb] [Process/Utility] Fix DR offsets for FreeBSD

[Michał Górny via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a8bfee2a356a2e70f854bf6d0b364798f4183795
      https://github.com/llvm/llvm-project/commit/a8bfee2a356a2e70f854bf6d0b364798f4183795
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-12 (Thu, 12 Nov 2020)

  Changed paths:
    M lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_i386.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_x86_64.cpp

  Log Message:
  -----------
  [lldb] [Process/Utility] Fix DR offsets for FreeBSD

Fix Debug Register offsets to be specified relatively to UserArea
on FreeBSD/amd64 and FreeBSD/i386, and add them to UserArea on i386.
This fixes overlapping GPRs and DRs in gdb-remote protocol, making it
impossible to correctly get and set debug registers from the LLDB
client.

Differential Revision: https://reviews.llvm.org/D91254


  Commit: f37834c7dcbe69405bf3e182d2b3e3227cc4a569
      https://github.com/llvm/llvm-project/commit/f37834c7dcbe69405bf3e182d2b3e3227cc4a569
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-12 (Thu, 12 Nov 2020)

  Changed paths:
    A lldb/test/Shell/Register/Inputs/x86-db-read.cpp
    A lldb/test/Shell/Register/x86-db-read.test

  Log Message:
  -----------
  [lldb] [test] Add a minimal test for x86 dbreg reading

Add a test verifying that after the 'watchpoint' command, new values
of x86 debug registers can be read back correctly.  The primary purpose
of this test is to catch broken DRn reading and help debugging it.

Differential Revision: https://reviews.llvm.org/D91264


Compare: https://github.com/llvm/llvm-project/compare/1115d1d08302...f37834c7dcbe