[all-commits] [llvm/llvm-project] cc575d: [flang][MSVC] Use list<Message> rather than forwar...

[Peter Klausler via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cc575dd2cefce3170655a026dbf058a42e1a4330
      https://github.com/llvm/llvm-project/commit/cc575dd2cefce3170655a026dbf058a42e1a4330
  Author: peter klausler <pklausler at nvidia.com>
  Date:   2020-11-11 (Wed, 11 Nov 2020)

  Changed paths:
    M flang/include/flang/Parser/char-buffer.h
    M flang/include/flang/Parser/instrumented-parser.h
    M flang/include/flang/Parser/message.h
    M flang/lib/Parser/basic-parsers.h
    M flang/lib/Parser/char-buffer.cpp
    M flang/lib/Parser/message.cpp

  Log Message:
  -----------
  [flang][MSVC] Use list<Message> rather than forward_list<> in Messages

The implementation of Messages with forward_list<> makes some
nonstandard assumptions about the validity of iterators that don't
hold up with MSVC's implementation.  Use list<> instead.  The
measured performance is comparable.

This change obviated a distinction between two member functions
of Messages, and the uses of one have been replaced with calls
to the other.

Similar usage in CharBuffer was also replaced for consistency.

Differential revision: https://reviews.llvm.org/D91210