[all-commits] [llvm/llvm-project] d76e01: [MachO] Allow the LC_IDENT load command

[Vedant Kumar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d76e01a6a7c26051146fa65776cf63eb17f46fa3
      https://github.com/llvm/llvm-project/commit/d76e01a6a7c26051146fa65776cf63eb17f46fa3
  Author: Vedant Kumar <vsk at apple.com>
  Date:   2020-11-11 (Wed, 11 Nov 2020)

  Changed paths:
    M llvm/lib/Object/MachOObjectFile.cpp
    R llvm/test/Object/Inputs/macho-invalid-ident-obsolete
    M llvm/test/Object/macho-invalid.test
    A llvm/test/ObjectYAML/MachO/lc-ident.yaml

  Log Message:
  -----------
  [MachO] Allow the LC_IDENT load command

xnu coredumps include an LC_IDENT load command. It's helpful to be able
to just ignore these. IIUC an interested client can grab the identifier
using the MachOObjectFile::load_commands() API.

The status quo is that llvm bails out when it finds an LC_IDENT because
the command is obsolete (see isLoadCommandObsolete).

Differential Revision: https://reviews.llvm.org/D91221