[all-commits] [llvm/llvm-project] 418f18: Revert "Reland [CFGuard] Add address-taken IAT tab...

[Hans via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 418f18c6cdfe56e77669e2f4d3df3bca1020156d
      https://github.com/llvm/llvm-project/commit/418f18c6cdfe56e77669e2f4d3df3bca1020156d
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-11-11 (Wed, 11 Nov 2020)

  Changed paths:
    M lld/COFF/DLL.cpp
    M lld/COFF/ICF.cpp
    M lld/COFF/InputFiles.cpp
    M lld/COFF/InputFiles.h
    M lld/COFF/Symbols.h
    M lld/COFF/Writer.cpp
    R lld/test/COFF/giats.s
    M llvm/include/llvm/MC/MCObjectFileInfo.h
    M llvm/lib/CodeGen/AsmPrinter/WinCFGuard.cpp
    M llvm/lib/MC/MCObjectFileInfo.cpp
    R llvm/test/CodeGen/WinCFGuard/cfguard-giats.ll
    M llvm/tools/llvm-readobj/COFFDumper.cpp

  Log Message:
  -----------
  Revert "Reland [CFGuard] Add address-taken IAT tables and delay-load support"

This broke both Firefox and Chromium (PR47905) due to what seems like dllimport
function not being handled correctly.

> This patch adds support for creating Guard Address-Taken IAT Entry Tables (.giats$y sections) in object files, matching the behavior of MSVC. These contain lists of address-taken imported functions, which are used by the linker to create the final GIATS table.
> Additionally, if any DLLs are delay-loaded, the linker must look through the .giats tables and add the respective load thunks of address-taken imports to the GFIDS table, as these are also valid call targets.
>
> Reviewed By: rnk
>
> Differential Revision: https://reviews.llvm.org/D87544

This reverts commit cfd8481da1adba1952e0f6ecd00440986e49a946.