[all-commits] [llvm/llvm-project] 91ce6f: [clangd] Abort rename when given the same name

Kirill Bobyrev via All-commits all-commits at lists.llvm.org
Wed Nov 11 02:14:19 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 91ce6fb5a65f75c1b29c898f2cb76e2c5d1ac681
      https://github.com/llvm/llvm-project/commit/91ce6fb5a65f75c1b29c898f2cb76e2c5d1ac681
  Author: Kirill Bobyrev <kbobyrev at google.com>
  Date:   2020-11-11 (Wed, 11 Nov 2020)

  Changed paths:
    M clang-tools-extra/clangd/refactor/Rename.cpp
    M clang-tools-extra/clangd/unittests/RenameTests.cpp

  Log Message:
  -----------
  [clangd] Abort rename when given the same name

When user wants to rename the symbol to the same name we shouldn't do any work.
Bail out early and return error to save compute.

Resolves: https://github.com/clangd/clangd/issues/580

Reviewed By: hokein

Differential Revision: https://reviews.llvm.org/D91134




More information about the All-commits mailing list