[all-commits] [llvm/llvm-project] cc5b4a: [mlir] Rework DialectConversion inlineRegionBefore

Tres via All-commits all-commits at lists.llvm.org
Wed Nov 11 01:42:54 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cc5b4a86036645db0fef997b7ae36bd613e6e429
      https://github.com/llvm/llvm-project/commit/cc5b4a86036645db0fef997b7ae36bd613e6e429
  Author: Tres Popp <tpopp at google.com>
  Date:   2020-11-11 (Wed, 11 Nov 2020)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    M mlir/test/Transforms/test-legalizer-full.mlir

  Log Message:
  -----------
  [mlir] Rework DialectConversion inlineRegionBefore

The previous logic for inlining a region A with N blocks into region B
would produce incorrect results on rollback for N greater than 1. This
rollback logic would leave blocks 1..N in region B and only move block 0
to region A.

The new inlining action recording stores the block move actions from N-1
to 0. Now on roll back, block 0 is moved to region A and then 1..N is
appended to the list of blocks in region A.

Differential Revision: https://reviews.llvm.org/D91185




More information about the All-commits mailing list