[all-commits] [llvm/llvm-project] c50faf: [lldb] Fix TestErrorMessages test on standalone bu...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c50faf5c9d7ca7a62cd59516c7de305b73f2455c
      https://github.com/llvm/llvm-project/commit/c50faf5c9d7ca7a62cd59516c7de305b73f2455c
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-11-10 (Tue, 10 Nov 2020)

  Changed paths:
    M lldb/test/Shell/helper/toolchain.py
    M lldb/test/Shell/lldb-server/TestErrorMessages.test

  Log Message:
  -----------
  [lldb] Fix TestErrorMessages test on standalone builds by adding lldb-server substitution

It seems that TestErrorMessages.test is failing on the standalone + Xcode builds
as lldb-server executable can't be found by lit's default PATH search. I assume
invoking lldb-server via a lit substitution gets this working again as
everything else is working, so that's what this patch is doing.

I had to add the lldb-server substitution as the test seems lldb-server specific
and we don't want it to default to debugserver on Darwin.

Using a substitution also seems in general like a good idea so that the commands
lit is printing on failure are using the full path to lldb-server and can be
re-run in a terminal.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D91155