[all-commits] [llvm/llvm-project] a852cf: [lldb] [test] Skip ObjC-based tests via 'objc' cat...

Michał Górny via All-commits all-commits at lists.llvm.org
Tue Nov 10 03:03:02 PST 2020 

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a852cf66ea5d130a09cd796b97b15c18059e95cd
      https://github.com/llvm/llvm-project/commit/a852cf66ea5d130a09cd796b97b15c18059e95cd
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-10 (Tue, 10 Nov 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/dotest.py
    M lldb/test/API/commands/expression/call-throws/TestCallThatThrows.py
    M lldb/test/API/commands/expression/context-object-objc/TestContextObjectObjc.py
    M lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py
    M lldb/test/API/commands/expression/import_builtin_fileid/TestImportBuiltinFileID.py
    M lldb/test/API/commands/expression/namespace_local_var_same_name_obj_c/TestNamespaceLocalVarSameNameObjC.py
    M lldb/test/API/commands/expression/persist_objc_pointeetype/TestPersistObjCPointeeType.py
    M lldb/test/API/commands/expression/po_verbosity/TestPoVerbosity.py
    M lldb/test/API/commands/expression/two-files/TestObjCTypeQueryFromOtherCompileUnit.py
    A lldb/test/API/commands/frame/recognizer/.categories
    M lldb/test/API/functionalities/breakpoint/objc/TestObjCBreakpoints.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCCF.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCExpr.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCKVO.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSBundle.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSData.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSDate.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSError.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSURL.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCPlain.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjNSException.py
    M lldb/test/API/functionalities/set-data/TestSetData.py
    M lldb/test/API/functionalities/tsan/multiple/TestTsanMultiple.py
    M lldb/test/API/lang/objc/bitfield_ivars/TestBitfieldIvars.py
    M lldb/test/API/lang/objc/blocks/TestObjCIvarsInBlocks.py
    M lldb/test/API/lang/objc/conflicting-definition/TestConflictingDefinition.py
    M lldb/test/API/lang/objc/direct-dispatch-step/TestObjCDirectDispatchStepping.py
    M lldb/test/API/lang/objc/exceptions/TestObjCExceptions.py
    M lldb/test/API/lang/objc/forward-decl/TestForwardDecl.py
    M lldb/test/API/lang/objc/foundation/TestConstStrings.py
    M lldb/test/API/lang/objc/foundation/TestFoundationDisassembly.py
    M lldb/test/API/lang/objc/foundation/TestObjCMethods.py
    M lldb/test/API/lang/objc/foundation/TestObjCMethods2.py
    M lldb/test/API/lang/objc/foundation/TestObjCMethodsNSArray.py
    M lldb/test/API/lang/objc/foundation/TestObjCMethodsNSError.py
    M lldb/test/API/lang/objc/foundation/TestObjCMethodsString.py
    M lldb/test/API/lang/objc/foundation/TestObjectDescriptionAPI.py
    M lldb/test/API/lang/objc/foundation/TestRuntimeTypes.py
    M lldb/test/API/lang/objc/foundation/TestSymbolTable.py
    M lldb/test/API/lang/objc/global_ptrs/TestGlobalObjects.py
    M lldb/test/API/lang/objc/hidden-ivars/TestHiddenIvars.py
    M lldb/test/API/lang/objc/ivar-IMP/TestObjCiVarIMP.py
    M lldb/test/API/lang/objc/modules-app-update/TestClangModulesAppUpdate.py
    M lldb/test/API/lang/objc/modules-auto-import/TestModulesAutoImport.py
    M lldb/test/API/lang/objc/modules-cache/TestClangModulesCache.py
    M lldb/test/API/lang/objc/modules-compile-error/TestModulesCompileError.py
    M lldb/test/API/lang/objc/modules-hash-mismatch/TestClangModulesHashMismatch.py
    M lldb/test/API/lang/objc/modules-incomplete/TestIncompleteModules.py
    M lldb/test/API/lang/objc/modules-inline-functions/TestModulesInlineFunctions.py
    M lldb/test/API/lang/objc/modules-non-objc-target/TestObjCModulesNonObjCTarget.py
    M lldb/test/API/lang/objc/modules-update/TestClangModulesUpdate.py
    M lldb/test/API/lang/objc/modules/TestObjCModules.py
    M lldb/test/API/lang/objc/objc++/TestObjCXX.py
    M lldb/test/API/lang/objc/objc-baseclass-sbtype/TestObjCBaseClassSBType.py
    M lldb/test/API/lang/objc/objc-builtin-types/TestObjCBuiltinTypes.py
    M lldb/test/API/lang/objc/objc-checker/TestObjCCheckers.py
    M lldb/test/API/lang/objc/objc-class-method/TestObjCClassMethod.py
    M lldb/test/API/lang/objc/objc-dyn-sbtype/TestObjCDynamicSBType.py
    M lldb/test/API/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
    M lldb/test/API/lang/objc/objc-foundation-dictionary-empty/TestNSDictionary0.py
    M lldb/test/API/lang/objc/objc-ivar-offsets/TestObjCIvarOffsets.py
    M lldb/test/API/lang/objc/objc-ivar-protocols/TestIvarProtocols.py
    M lldb/test/API/lang/objc/objc-ivar-stripped/TestObjCIvarStripped.py
    M lldb/test/API/lang/objc/objc-new-syntax/TestObjCNewSyntaxArray.py
    M lldb/test/API/lang/objc/objc-new-syntax/TestObjCNewSyntaxDictionary.py
    M lldb/test/API/lang/objc/objc-new-syntax/TestObjCNewSyntaxLiteral.py
    M lldb/test/API/lang/objc/objc-optimized/TestObjcOptimized.py
    M lldb/test/API/lang/objc/objc-property/TestObjCProperty.py
    M lldb/test/API/lang/objc/objc-runtime-ivars/TestRuntimeIvars.py
    M lldb/test/API/lang/objc/objc-static-method-stripped/TestObjCStaticMethodStripped.py
    M lldb/test/API/lang/objc/objc-static-method/TestObjCStaticMethod.py
    M lldb/test/API/lang/objc/objc-stepping/TestObjCStepping.py
    M lldb/test/API/lang/objc/objc-struct-argument/TestObjCStructArgument.py
    M lldb/test/API/lang/objc/objc-struct-return/TestObjCStructReturn.py
    M lldb/test/API/lang/objc/objc-super/TestObjCSuper.py
    M lldb/test/API/lang/objc/objc_direct-methods/TestObjCDirectMethods.py
    M lldb/test/API/lang/objc/orderedset/TestOrderedSet.py
    M lldb/test/API/lang/objc/print-obj/TestPrintObj.py
    M lldb/test/API/lang/objc/ptr_refs/TestPtrRefsObjC.py
    M lldb/test/API/lang/objc/radar-9691614/TestObjCMethodReturningBOOL.py
    M lldb/test/API/lang/objc/rdar-10967107/TestRdar10967107.py
    M lldb/test/API/lang/objc/rdar-11355592/TestRdar11355592.py
    M lldb/test/API/lang/objc/rdar-12408181/TestRdar12408181.py
    M lldb/test/API/lang/objc/real-definition/TestRealDefinition.py
    M lldb/test/API/lang/objc/self/TestObjCSelf.py
    M lldb/test/API/lang/objc/single-entry-dictionary/TestObjCSingleEntryDictionary.py
    M lldb/test/API/lang/objc/unicode-string/TestUnicodeString.py
    M lldb/test/API/lang/objc/variadic_methods/TestVariadicMethods.py
    A lldb/test/API/lang/objcxx/.categories
    M lldb/test/API/lang/objcxx/class-name-clash/TestNameClash.py
    M lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
    M lldb/test/API/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
    M lldb/test/API/lang/objcxx/objcxx-ivar-vector/TestIvarVector.py
    A lldb/test/API/macosx/nslog/.categories
    M lldb/test/API/python_api/objc_type/TestObjCType.py
    M lldb/test/API/python_api/sbtype_typeclass/TestSBTypeTypeClass.py

  Log Message:
  -----------
  [lldb] [test] Skip ObjC-based tests via 'objc' category

Replace the plethora of ObjC-implied 'skipUnlessDarwin' decorators
with marking tests as 'objc' category (whenever missing), and skip all
ObjC tests on non-Darwin platforms.  I have used '.categories' file
wherever it was present already or all (>1) tests were relying on ObjC,
and explicit add_test_categories() where there was only one test.

Differential Revision: https://reviews.llvm.org/D91056


  Commit: 311cca8bbf882cd93124d5ee9f40ee47f5e1f57d
      https://github.com/llvm/llvm-project/commit/311cca8bbf882cd93124d5ee9f40ee47f5e1f57d
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-10 (Tue, 10 Nov 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/test_result.py
    R lldb/test/API/api/multiple-debuggers/.categories
    A lldb/test/API/api/multiple-debuggers/categories
    R lldb/test/API/commands/command/.categories
    A lldb/test/API/commands/command/categories
    R lldb/test/API/commands/expression/.categories
    A lldb/test/API/commands/expression/categories
    R lldb/test/API/commands/expression/completion/.categories
    A lldb/test/API/commands/expression/completion/categories
    R lldb/test/API/commands/expression/import-std-module/.categories
    A lldb/test/API/commands/expression/import-std-module/categories
    R lldb/test/API/commands/frame/recognizer/.categories
    A lldb/test/API/commands/frame/recognizer/categories
    R lldb/test/API/commands/watchpoints/.categories
    A lldb/test/API/commands/watchpoints/categories
    R lldb/test/API/functionalities/abbreviation/.categories
    A lldb/test/API/functionalities/abbreviation/categories
    R lldb/test/API/functionalities/alias/.categories
    A lldb/test/API/functionalities/alias/categories
    R lldb/test/API/functionalities/asan/.categories
    A lldb/test/API/functionalities/asan/categories
    R lldb/test/API/functionalities/backticks/.categories
    A lldb/test/API/functionalities/backticks/categories
    R lldb/test/API/functionalities/completion/.categories
    A lldb/test/API/functionalities/completion/categories
    R lldb/test/API/functionalities/darwin_log/.categories
    A lldb/test/API/functionalities/darwin_log/categories
    R lldb/test/API/functionalities/data-formatter/.categories
    A lldb/test/API/functionalities/data-formatter/categories
    R lldb/test/API/functionalities/data-formatter/data-formatter-objc/.categories
    A lldb/test/API/functionalities/data-formatter/data-formatter-objc/categories
    R lldb/test/API/functionalities/load_unload/.categories
    A lldb/test/API/functionalities/load_unload/categories
    R lldb/test/API/functionalities/load_using_paths/.categories
    A lldb/test/API/functionalities/load_using_paths/categories
    R lldb/test/API/functionalities/mtc/.categories
    A lldb/test/API/functionalities/mtc/categories
    R lldb/test/API/functionalities/thread/step_until/.categories
    A lldb/test/API/functionalities/thread/step_until/categories
    R lldb/test/API/functionalities/tsan/.categories
    A lldb/test/API/functionalities/tsan/categories
    R lldb/test/API/functionalities/ubsan/.categories
    A lldb/test/API/functionalities/ubsan/categories
    R lldb/test/API/functionalities/wrong_commands/.categories
    A lldb/test/API/functionalities/wrong_commands/categories
    R lldb/test/API/lang/c/step-target/.categories
    A lldb/test/API/lang/c/step-target/categories
    R lldb/test/API/lang/cpp/char1632_t/.categories
    A lldb/test/API/lang/cpp/char1632_t/categories
    R lldb/test/API/lang/cpp/wchar_t/.categories
    A lldb/test/API/lang/cpp/wchar_t/categories
    R lldb/test/API/lang/objc/.categories
    A lldb/test/API/lang/objc/categories
    R lldb/test/API/lang/objc/objc-dyn-sbtype/.categories
    A lldb/test/API/lang/objc/objc-dyn-sbtype/categories
    R lldb/test/API/lang/objcxx/.categories
    A lldb/test/API/lang/objcxx/categories
    R lldb/test/API/macosx/nslog/.categories
    A lldb/test/API/macosx/nslog/categories
    R lldb/test/API/python_api/.categories
    A lldb/test/API/python_api/categories
    R lldb/test/API/python_api/watchpoint/.categories
    A lldb/test/API/python_api/watchpoint/categories
    R lldb/test/API/tools/lldb-server/.categories
    A lldb/test/API/tools/lldb-server/categories
    R lldb/test/API/tools/lldb-vscode/.categories
    A lldb/test/API/tools/lldb-vscode/categories

  Log Message:
  -----------
  [lldb] [test] Rename '.categories' to 'categories'

Make category-specifying files visible.  There is really no good reason
to keep them hidden, and having them visible increases the chances
that someone will actually spot them.

Differential Revision: https://reviews.llvm.org/D91065


Compare: https://github.com/llvm/llvm-project/compare/462dd4f80358...311cca8bbf88

More information about the All-commits mailing list