[all-commits] [llvm/llvm-project] 6ac12b: [lldb] Destory the debugger in the Driver dtor (NFC)

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6ac12b5b6c5dc2c705f6e638cf6f5d50118abe92
      https://github.com/llvm/llvm-project/commit/6ac12b5b6c5dc2c705f6e638cf6f5d50118abe92
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M lldb/tools/driver/Driver.cpp

  Log Message:
  -----------
  [lldb] Destory the debugger in the Driver dtor (NFC)


  Commit: 0ca90eb3350b9e8c606fdf1ca0496e0bf3e330ec
      https://github.com/llvm/llvm-project/commit/0ca90eb3350b9e8c606fdf1ca0496e0bf3e330ec
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M lldb/tools/driver/Driver.cpp

  Log Message:
  -----------
  [lldb] Don't use ::exit but instead return from the driver loop (NFC)

This fixes a reproducer test failure that was caused by the undefined
order in which global destructors run. More concretely, the static
instance of the RealFileSystem had been destroyed before we finalized
the reproducer, which uses it to copy files into the reproducer. By
exiting normally, we call SBDebugger::Terminate and finalize the
reproducer before any static dtors are run.


Compare: https://github.com/llvm/llvm-project/compare/e84c3b2fc828...0ca90eb3350b