[all-commits] [llvm/llvm-project] 8b5a3e: [MLIR] Change FuncOp assembly syntax to print visi...

[Rahul Joshi via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8b5a3e46326f646c3cca187058c2ef71910daeb0
      https://github.com/llvm/llvm-project/commit/8b5a3e46326f646c3cca187058c2ef71910daeb0
  Author: Rahul Joshi <jurahul at google.com>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mlir/docs/SymbolsAndSymbolTables.md
    M mlir/include/mlir/IR/FunctionImplementation.h
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/include/mlir/IR/SymbolTable.h
    M mlir/include/mlir/Transforms/Passes.td
    M mlir/lib/IR/Function.cpp
    M mlir/lib/IR/FunctionImplementation.cpp
    M mlir/lib/IR/SymbolTable.cpp
    M mlir/lib/Parser/Parser.cpp
    M mlir/test/Conversion/AsyncToLLVM/convert-to-llvm.mlir
    M mlir/test/Examples/Toy/Ch4/codegen.toy
    M mlir/test/Examples/Toy/Ch4/shape_inference.mlir
    M mlir/test/Examples/Toy/Ch5/codegen.toy
    M mlir/test/Examples/Toy/Ch5/shape_inference.mlir
    M mlir/test/Examples/Toy/Ch6/codegen.toy
    M mlir/test/Examples/Toy/Ch6/shape_inference.mlir
    M mlir/test/Examples/Toy/Ch7/codegen.toy
    M mlir/test/Examples/Toy/Ch7/shape_inference.mlir
    M mlir/test/Examples/Toy/Ch7/struct-codegen.toy
    M mlir/test/IR/core-ops.mlir
    M mlir/test/Transforms/inlining-dce.mlir
    M mlir/test/Transforms/sccp-callgraph.mlir
    M mlir/test/Transforms/test-symbol-dce.mlir
    M mlir/test/mlir-reduce/dce-test.mlir

  Log Message:
  -----------
  [MLIR] Change FuncOp assembly syntax to print visibility inline instead of in attrib dict.

- Change syntax for FuncOp to be `func <visibility>? @name` instead of printing the
  visibility in the attribute dictionary.
- Since printFunctionLikeOp() and parseFunctionLikeOp() are also used by other
  operations, make the "inline visibility" an opt-in feature.
- Updated unit test to use and check the new syntax.

Differential Revision: https://reviews.llvm.org/D90859