[all-commits] [llvm/llvm-project] 893003: Don't dereference a dyn_cast<> result - use cast<>...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Sun Nov 8 05:08:10 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8930032f53322405ca2d06cac78b9503542e5b62
      https://github.com/llvm/llvm-project/commit/8930032f53322405ca2d06cac78b9503542e5b62
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-11-08 (Sun, 08 Nov 2020)

  Changed paths:
    M clang/lib/CodeGen/CodeGenModule.cpp

  Log Message:
  -----------
  Don't dereference a dyn_cast<> result - use cast<> instead. NFCI.

We were relying on the dyn_cast<> succeeding - better use cast<> and have it assert that its the correct type than dereference a null result.


  Commit: b11eaf561714969cc119bd7cdaf72bd8c5f56158
      https://github.com/llvm/llvm-project/commit/b11eaf561714969cc119bd7cdaf72bd8c5f56158
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-11-08 (Sun, 08 Nov 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp

  Log Message:
  -----------
  [DSE] Don't dereference a dyn_cast<> result - use cast<> instead. NFCI.

We were relying on the dyn_cast<> succeeding - better use cast<> and have it assert that its the correct type than dereference a null result.


Compare: https://github.com/llvm/llvm-project/compare/0fe91ad463fe...b11eaf561714


More information about the All-commits mailing list