[all-commits] [llvm/llvm-project] b643de: [lldb] [test] Fix TestGdbRemoteThreadName code on ...

[Michał Górny via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b643deb03fb935d414f74e07b702ebb4e5c33bf3
      https://github.com/llvm/llvm-project/commit/b643deb03fb935d414f74e07b702ebb4e5c33bf3
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-05 (Thu, 05 Nov 2020)

  Changed paths:
    M lldb/test/API/tools/lldb-server/thread-name/main.cpp

  Log Message:
  -----------
  [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD

Fix TestGdbRemoteThreadName to call ::pthread_setname_np instead
of ::pthread_set_name_np on FreeBSD.  While technically both names
are correct, the former is preferable because of compatibility
with Linux.  Furthermore, the latter requires `#include <pthread_np.h>`
that was missing causing the test to fail to compile.

Differential Revision: https://reviews.llvm.org/D90862


  Commit: 40140e122f8b6512ebe22efc32dacf14f10117f6
      https://github.com/llvm/llvm-project/commit/40140e122f8b6512ebe22efc32dacf14f10117f6
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-05 (Thu, 05 Nov 2020)

  Changed paths:
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.cpp
    M lldb/source/Plugins/Process/FreeBSDRemote/NativeThreadFreeBSD.h
    M lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py

  Log Message:
  -----------
  [lldb] [Process/FreeBSDRemote] Remove thread name caching

Remove the thread name caching code.  It does not handle the possibility
of thread name changing between requests, therefore breaking
TestGdbRemoteThreadName.  While technically we could cache the results
and reset the cache on resuming process, the gain from doing that
does not seem worth the effort.

Differential Revision: https://reviews.llvm.org/D90863


Compare: https://github.com/llvm/llvm-project/compare/b79e990f4019...40140e122f8b