[all-commits] [llvm/llvm-project] 6ba2c2: [lldb] [test/Shell] Simplify -pthread condition

Michał Górny via All-commits all-commits at lists.llvm.org
Thu Nov 5 08:50:43 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6ba2c2bf90f23381c1d052acb010cee364bebe8e
      https://github.com/llvm/llvm-project/commit/6ba2c2bf90f23381c1d052acb010cee364bebe8e
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-05 (Thu, 05 Nov 2020)

  Changed paths:
    M lldb/test/Shell/helper/toolchain.py

  Log Message:
  -----------
  [lldb] [test/Shell] Simplify -pthread condition

Pass -pthread on all systems except for Darwin and Windows.
Suggested by Pavel Labath.


  Commit: 2c2eb5e6702bf3bbb8fb8f09790b1ab7b139e879
      https://github.com/llvm/llvm-project/commit/2c2eb5e6702bf3bbb8fb8f09790b1ab7b139e879
  Author: Michał Górny <mgorny at moritz.systems>
  Date:   2020-11-05 (Thu, 05 Nov 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/dotest.py
    M lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp
    M lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
    M lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py
    M lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py
    M lldb/test/API/commands/expression/formatters/TestFormatters.py
    M lldb/test/API/commands/expression/no-deadlock/TestExprDoesntBlock.py
    M lldb/test/API/commands/register/register/register_command/TestRegisters.py
    M lldb/test/API/commands/watchpoints/multiple_threads/TestWatchpointMultipleThreads.py
    M lldb/test/API/functionalities/avoids-fd-leak/TestFdLeak.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-python-synth/TestDataFormatterPythonSynth.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-synthtype/TestDataFormatterSynthType.py
    M lldb/test/API/functionalities/data-formatter/data-formatter-synthval/TestDataFormatterSynthVal.py
    M lldb/test/API/functionalities/data-formatter/varscript_formatting/TestDataFormatterVarScriptFormatting.py
    M lldb/test/API/functionalities/deleted-executable/TestDeletedExecutable.py
    M lldb/test/API/functionalities/exec/TestExec.py
    M lldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py
    M lldb/test/API/functionalities/inferior-crashing/TestInferiorCrashingStep.py
    M lldb/test/API/functionalities/inferior-crashing/recursive-inferior/TestRecursiveInferiorStep.py
    M lldb/test/API/functionalities/load_unload/TestLoadUnload.py
    M lldb/test/API/functionalities/load_using_paths/TestLoadUsingPaths.py
    M lldb/test/API/functionalities/longjmp/TestLongjmp.py
    M lldb/test/API/functionalities/plugins/python_os_plugin/stepping_plugin_threads/TestOSPluginStepping.py
    M lldb/test/API/functionalities/signal/TestSendSignal.py
    M lldb/test/API/functionalities/signal/raise/TestRaise.py
    M lldb/test/API/functionalities/thread/create_after_attach/TestCreateAfterAttach.py
    M lldb/test/API/functionalities/thread/exit_during_step/TestExitDuringStep.py
    M lldb/test/API/functionalities/thread/state/TestThreadStates.py
    M lldb/test/API/lang/c/modules/TestCModules.py
    M lldb/test/API/lit.cfg.py
    M lldb/test/API/python_api/event/TestEvents.py
    M lldb/test/API/tools/lldb-server/TestGdbRemote_qThreadStopInfo.py
    M lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
    M lldb/test/API/tools/lldb-server/commandline/TestStubSetSID.py
    M lldb/test/API/tools/lldb-server/libraries-svr4/TestGdbRemoteLibrariesSvr4Support.py
    M lldb/test/API/tools/lldb-server/register-reading/TestGdbRemoteGPacket.py
    M lldb/test/API/tools/lldb-server/thread-name/TestGdbRemoteThreadName.py
    M lldb/test/Shell/ExecControl/StopHook/stop-hook-threads.test
    M lldb/test/Shell/Recognizer/assert.test
    M lldb/test/Shell/lit.cfg.py

  Log Message:
  -----------
  [lldb] Enable FreeBSDRemote plugin by default and update test status

The new FreeBSDRemote plugin has reached feature parity on i386
and amd64 targets.  Use it by default on these architectures, while
allowing the use of the legacy plugin via FREEBSD_LEGACY_PLUGIN envvar.

Revisit the method of switching plugins.  Apparently, the return value
of PlatformFreeBSD::CanDebugProcess() is what really decides whether
the legacy or the new plugin is used.

Update the test status.  Reenable the tests that were previously
disabled on FreeBSD and do not cause hangs or are irrelevant to FreeBSD.
Mark all tests that fail reliably as expectedFailure.  For now, tests
that are flaky (i.e. produce unstable results) are left enabled
and cause unpredictable test failures.

Differential Revision: https://reviews.llvm.org/D90757


Compare: https://github.com/llvm/llvm-project/compare/15694fd6ad95...2c2eb5e6702b


More information about the All-commits mailing list