[all-commits] [llvm/llvm-project] 2f84b5: [lldb] Also Catch invalid calls to TestPExpectTest...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2f84b59a4cf92a0ce1b985e7f44e17483efa33c0
      https://github.com/llvm/llvm-project/commit/2f84b59a4cf92a0ce1b985e7f44e17483efa33c0
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-11-05 (Thu, 05 Nov 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lldbpexpect.py
    A lldb/test/API/test_utils/TestPExpectTest.py

  Log Message:
  -----------
  [lldb] Also Catch invalid calls to TestPExpectTest's expect()

This is a follow up to D88792 which found an issue in a call to PExpectTest's
expect function that allows passing a string to the `substrs` parameter. However
this issue was found by just grepping and TestPExpect's expect function is still
accepting a single string as a value to `substrs`.

This patch adds the same sanity check that D88792 added to the PExpectTest's
implementation of `expect` and also adds a small test for it.

Reviewed By: kastiglione, JDevlieghere

Differential Revision: https://reviews.llvm.org/D89302