[all-commits] [llvm/llvm-project] 5d6457: [lldb] Delete Value::Vector class

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d64574301836c4c17127794121d49a62d24f803
      https://github.com/llvm/llvm-project/commit/5d64574301836c4c17127794121d49a62d24f803
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-11-04 (Wed, 04 Nov 2020)

  Changed paths:
    M lldb/include/lldb/Core/Value.h
    M lldb/source/Core/Value.cpp
    M lldb/source/Core/ValueObject.cpp
    M lldb/source/Core/ValueObjectVariable.cpp
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/source/Target/ABI.cpp

  Log Message:
  -----------
  [lldb] Delete Value::Vector class

This class and it's surroundings contain a lot of shady code, but as far
as I can tell all of that code is unreachable (there is no code actually
setting the value to eValueTypeVector).

According to history this class was introduced in 2012 in
r167033/0665a0f09. At that time, the code seemed to serve some purpose,
and it had two entry points (in Value::SetContext and
ClangExpressionDeclMap::LookupDecl). The first entry point was deleted
in D17897 and the second one in r179842/44342735.

The stated purpose of the patch introducing this class was to fix
TestRegisters.py, and "expr $xmm0" in particular. Both of these things
function perfectly well these days without this class.