[all-commits] [llvm/llvm-project] 8e5156: [libc++] Harden tests against executors not runnin...

Louis Dionne via All-commits all-commits at lists.llvm.org
Tue Nov 3 13:03:56 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e5156f6b0d17e2703566a296601706fdc09bccb
      https://github.com/llvm/llvm-project/commit/8e5156f6b0d17e2703566a296601706fdc09bccb
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-11-03 (Tue, 03 Nov 2020)

  Changed paths:
    M libcxx/test/libcxx/selftest/remote-substitutions.sh.cpp
    A libcxx/test/std/input.output/iostream.objects/check-stderr.sh
    A libcxx/test/std/input.output/iostream.objects/check-stdout.sh
    M libcxx/test/std/input.output/iostream.objects/narrow.stream.objects/cerr.sh.cpp
    M libcxx/test/std/input.output/iostream.objects/narrow.stream.objects/cin.sh.cpp
    M libcxx/test/std/input.output/iostream.objects/narrow.stream.objects/clog.sh.cpp
    M libcxx/test/std/input.output/iostream.objects/narrow.stream.objects/cout.sh.cpp
    A libcxx/test/std/input.output/iostream.objects/send-stdin.sh
    M libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcerr.sh.cpp
    M libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcin.sh.cpp
    M libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wclog.sh.cpp
    M libcxx/test/std/input.output/iostream.objects/wide.stream.objects/wcout.sh.cpp

  Log Message:
  -----------
  [libc++] Harden tests against executors not running tests in a shell

Some executors do not run the tests in a shell, and so assuming that
they can understand shell builtins is wrong. Instead, call Bash
directly to do what we need to do.

This still requires the executor to be able to run Bash, but at least
it does not require it to interpret command lines in the Bash language.




More information about the All-commits mailing list