[all-commits] [llvm/llvm-project] c06c02: [AMDGPU] Regenerate load i16 tests to use update_l...

[Simon Pilgrim via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c06c02bd1f162cf154996ea064a5d19054a4e364
      https://github.com/llvm/llvm-project/commit/c06c02bd1f162cf154996ea064a5d19054a4e364
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-11-03 (Tue, 03 Nov 2020)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/load-constant-i16.ll
    M llvm/test/CodeGen/AMDGPU/load-global-i16.ll

  Log Message:
  -----------
  [AMDGPU] Regenerate load i16 tests to use update_llc_test_checks.py script. NFCI.

Necessary for upcoming KnownBits::lshr support.


  Commit: cb798f040a768dbd1fc918fe581088b2fe7932bf
      https://github.com/llvm/llvm-project/commit/cb798f040a768dbd1fc918fe581088b2fe7932bf
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-11-03 (Tue, 03 Nov 2020)

  Changed paths:
    M llvm/include/llvm/Support/KnownBits.h
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
    M llvm/lib/Support/KnownBits.cpp
    M llvm/test/CodeGen/AMDGPU/load-constant-i16.ll
    M llvm/test/CodeGen/AMDGPU/load-global-i16.ll

  Log Message:
  -----------
  [DAG] computeKnownBits - Move (most) ISD::SRL handling into KnownBits::lshr

As discussed on D90527, we should be be trying to move shift handling functionality into KnownBits to avoid code duplication in SelectionDAG/GlobalISel/ValueTracking.

The refactor to use the KnownBits fixed/min/max constant helpers allows us to hit a couple of cases that we were missing before.

We still need the getValidMinimumShiftAmountConstant case as KnownBits doesn't handle per-element vector cases.


Compare: https://github.com/llvm/llvm-project/compare/d9a4f936d05c...cb798f040a76