[all-commits] [llvm/llvm-project] 008b9d: Make the implicit nesting behavior of the PassMana...

Mehdi Amini via All-commits all-commits at lists.llvm.org
Tue Nov 3 03:18:12 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 008b9d97cb791b8e3d89c7bc3ddd714ca3a61c80
      https://github.com/llvm/llvm-project/commit/008b9d97cb791b8e3d89c7bc3ddd714ca3a61c80
  Author: Mehdi Amini <joker.eph at gmail.com>
  Date:   2020-11-03 (Tue, 03 Nov 2020)

  Changed paths:
    M mlir/examples/toy/Ch5/toyc.cpp
    M mlir/examples/toy/Ch6/toyc.cpp
    M mlir/examples/toy/Ch7/toyc.cpp
    M mlir/include/mlir/Pass/PassManager.h
    M mlir/lib/Pass/Pass.cpp
    M mlir/lib/Support/MlirOptMain.cpp
    M mlir/test/lib/Transforms/TestConvVectorization.cpp
    M mlir/test/lib/Transforms/TestDynamicPipeline.cpp
    M mlir/unittests/Pass/PassManagerTest.cpp

  Log Message:
  -----------
  Make the implicit nesting behavior of the PassManager user-controllable and default to false

This is an error prone behavior, I frequently have ~20 min debugging sessions when I hit
an unexpected implicit nesting. This default makes the C++ API safer for users.

Depends On D90669

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D90671




More information about the All-commits mailing list