[all-commits] [llvm/llvm-project] 8954fd: [libcxx] Fix regression where `ninja all` doesn't ...

Nico Weber via All-commits all-commits at lists.llvm.org
Sun Nov 1 18:39:04 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8954fd436c729796615bac11b3553c4341f01a82
      https://github.com/llvm/llvm-project/commit/8954fd436c729796615bac11b3553c4341f01a82
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-11-01 (Sun, 01 Nov 2020)

  Changed paths:
    M libcxx/include/CMakeLists.txt

  Log Message:
  -----------
  [libcxx] Fix regression where `ninja all` doesn't copy libcxx headers

Before 6db314e86b2674, when running cmake with clang, libcxx, and
compiler-rt enabled, building `ninja all` would run the
generate-cxx-headers target, due to the sanitizers depending on it.

After 6db314e86b2674, if LIBCXX_ENABLE_SHARED and LIBCXX_ENABLE_STATIC
and LIBCXX_INCLUDE_TESTS and LIBCXX_ENABLE_EXPERIMENTAL_LIBRARY are
disabled (https://reviews.llvm.org/D82702#2153627), `ninja all`
no longer copies the libcxx headers, which means clang can't compile
programs like `#include <string>` on macOS.

Explicitly add the copy target to the all target to restore the old
behavior.




More information about the All-commits mailing list