[all-commits] [llvm/llvm-project] 0e2066: [MCA][LSUnit] Correctly update the internal group ...

Andrea Di Biagio via All-commits all-commits at lists.llvm.org
Sat Oct 31 05:00:52 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e20666db3ac280affe82d31b6c144923704e9c4
      https://github.com/llvm/llvm-project/commit/0e20666db3ac280affe82d31b6c144923704e9c4
  Author: Andrea Di Biagio <andrea.dibiagio at sony.com>
  Date:   2020-10-31 (Sat, 31 Oct 2020)

  Changed paths:
    M llvm/lib/MCA/HardwareUnits/LSUnit.cpp
    A llvm/test/tools/llvm-mca/X86/BtVer2/stmxcsr-ldmxcsr.s
    A llvm/test/tools/llvm-mca/X86/Haswell/stmxcsr-ldmxcsr.s

  Log Message:
  -----------
  [MCA][LSUnit] Correctly update the internal group flags on store barrier execution. Fixes PR48024.

This is likely to be a regressigion introduced by my last refactoring of the
LSUnit (commit 5578ec32f9c4f). Before this patch, the
"CurrentStoreBarrierGroupID" index was not correctly reset on store barrier
executions.  This was leading to unexpected crashes like the one reported as
PR48024.




More information about the All-commits mailing list