[all-commits] [llvm/llvm-project] c11686: [flang] Add warning for FINAL pitfall

[Peter Klausler via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c1168676a0c211641cbd5945eb46702fc50e56de
      https://github.com/llvm/llvm-project/commit/c1168676a0c211641cbd5945eb46702fc50e56de
  Author: peter klausler <pklausler at nvidia.com>
  Date:   2020-10-30 (Fri, 30 Oct 2020)

  Changed paths:
    M flang/include/flang/Semantics/symbol.h
    M flang/lib/Semantics/check-declarations.cpp
    M flang/lib/Semantics/symbol.cpp
    A flang/test/Semantics/final02.f90

  Log Message:
  -----------
  [flang] Add warning for FINAL pitfall

Fortran's FINAL feature is sensitive to object rank.
When an object's rank excludes it from finalization, but
the type has FINAL subroutines for other ranks, emit
a warning.  This should be especially helpful in the
case of a scalar FINAL subroutine not being declared
(IMPURE) ELEMENTAL.

Differential revision: https://reviews.llvm.org/D90495