[all-commits] [llvm/llvm-project] 79657e: [Support] PR42623: Avoid setting the delete-on-clo...

[Ronald Wampler via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 79657e2339b58bc01fe1b85a448bb073d57d90bb
      https://github.com/llvm/llvm-project/commit/79657e2339b58bc01fe1b85a448bb073d57d90bb
  Author: Ronald Wampler <rdwampler at gmail.com>
  Date:   2020-10-30 (Fri, 30 Oct 2020)

  Changed paths:
    M llvm/lib/Support/Windows/Path.inc

  Log Message:
  -----------
  [Support] PR42623: Avoid setting the delete-on-close bit if a TempFile doesn't reside on a local drive

On Windows, after commit 881ba104656c40098d4bc90c52613c08136f0fe1, tools
using TempFile would error with "bad file descriptor" when writing the
file on a network drive. It appears that setting the delete-on-close bit via
SetFileInformationByHandle/FileDispositionInfo prevented it from
accessing the file on network drives, and although using
FILE_DISPOSITION_INFO seems to work, it causes other troubles.

Differential Revision: https://reviews.llvm.org/D81803