[all-commits] [llvm/llvm-project] a463ea: [mlir][ASM] Refactor how attribute/type aliases ar...

River Riddle via All-commits all-commits at lists.llvm.org
Fri Oct 30 00:40:21 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a463ea50a4d6d256d91778ec0b40bc6ed6f303f7
      https://github.com/llvm/llvm-project/commit/a463ea50a4d6d256d91778ec0b40bc6ed6f303f7
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-10-30 (Fri, 30 Oct 2020)

  Changed paths:
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/IR/MLIRContext.cpp
    M mlir/test/Dialect/Affine/affine-loop-invariant-code-motion.mlir
    M mlir/test/Dialect/Affine/canonicalize.mlir
    M mlir/test/Dialect/Affine/ops.mlir
    M mlir/test/Dialect/SCF/for-loop-specialization.mlir
    M mlir/test/Dialect/SCF/parallel-loop-tiling.mlir
    M mlir/test/IR/memory-ops.mlir
    A mlir/test/IR/print-attr-type-aliases.mlir
    M mlir/test/Transforms/loop-fusion.mlir
    M mlir/test/Transforms/loop-invariant-code-motion.mlir
    M mlir/test/lib/Dialect/Test/TestDialect.cpp

  Log Message:
  -----------
  [mlir][ASM] Refactor how attribute/type aliases are specified.

Previously they were separated into "instance" and "kind" aliases, and also required that the dialect know ahead of time all of the instances that would have a corresponding alias. This approach was very clunky and not ergonomic to interact with. The new approach is to provide the dialect with an instance  of an attribute/type to provide an alias for, fully replacing the original split approach.

Differential Revision: https://reviews.llvm.org/D89354




More information about the All-commits mailing list