[all-commits] [llvm/llvm-project] ee7e03: [Reassociate][test] Delete improper -NOT patterns ...

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Oct 28 23:59:30 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ee7e03e19e7447985d4710dd93d94bdecc665989
      https://github.com/llvm/llvm-project/commit/ee7e03e19e7447985d4710dd93d94bdecc665989
  Author: Fangrui Song <i at maskray.me>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M llvm/test/Transforms/Reassociate/erase_inst_made_change.ll
    M llvm/test/Transforms/Reassociate/reassociate-deadinst.ll

  Log Message:
  -----------
  [Reassociate][test] Delete improper -NOT patterns to work with -enable-new-pm=1

The two tests rely on LegacyInlinerBase::doFinalization to remove
Function::isDefTriviallyDead() functions. The new PM does not have the behavior.
The -NEXT patterns checking the emptiness are actually sufficient.

Note, reassociate-deadinst.ll has become stale - it no longer catches
the problem r285380 intended. Unfortunately it is difficult to craft a
new test because it is actually pretty difficult to break it with
`MadeChange = true;` all over the file.




More information about the All-commits mailing list