[all-commits] [llvm/llvm-project] 2488e4: [llvm-lit] Improve the error message when make_pat...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Oct 28 14:06:57 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2488e444297f5813613d8fb76fb1f3378fb9171e
      https://github.com/llvm/llvm-project/commit/2488e444297f5813613d8fb76fb1f3378fb9171e
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-10-28 (Wed, 28 Oct 2020)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [llvm-lit] Improve the error message when make_paths_relative() fails

Previously, if make_paths_relative() failed due to some reason, it would
happily keep going and set the ${out_pathlist} to the standard output
of the command, which would be the empty string if the command failed.

This can lead to issues that are difficult to diagnose, since the calling
code will usually try to keep going with a variable that was set to the
empty string.

Differential Revision: https://reviews.llvm.org/D89985




More information about the All-commits mailing list