[all-commits] [llvm/llvm-project] 1f933f: [lldb][NFC] Rewrite TestQuoting

Raphael Isemann via All-commits all-commits at lists.llvm.org
Tue Oct 27 03:13:01 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f933ff999f2c0373c79ddf23539873cbfa923e5
      https://github.com/llvm/llvm-project/commit/1f933ff999f2c0373c79ddf23539873cbfa923e5
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M lldb/test/API/commands/settings/quoting/TestQuoting.py

  Log Message:
  -----------
  [lldb][NFC] Rewrite TestQuoting

TestQuoting's different test methods all build their own test binaries but
we can just reuse the same test binary by merging all asserts into one method.
This reduces the test runtime from 8 seconds to 4 seconds on my machine.
This also removes the ability to have partial failures in this test, but given
how rarely this code is touched this seems like a fair tradeoff (and we will be
able to re-add this feature once we updated our test framework).

Some other small changes:
  * Fixed that we cleanup "stdout.txt" instead of "output.txt" in the cleanup.
  * Fixed some formatting issues.
  * Call `build` instead of directly calling `buildDefault`.




More information about the All-commits mailing list