[all-commits] [llvm/llvm-project] ba71a0: [MemProf] Decouple memprof build from COMPILER_RT_...

[Teresa Johnson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ba71a0746f31a2f5f9af992f569a9418133a9a38
      https://github.com/llvm/llvm-project/commit/ba71a0746f31a2f5f9af992f569a9418133a9a38
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2020-10-26 (Mon, 26 Oct 2020)

  Changed paths:
    M compiler-rt/include/CMakeLists.txt
    M compiler-rt/lib/CMakeLists.txt

  Log Message:
  -----------
  [MemProf] Decouple memprof build from COMPILER_RT_BUILD_SANITIZERS

The MemProf compiler-rt support relies on some of the support only built
when COMPILER_RT_BUILD_SANITIZERS was enabled. This showed up in some
initial bot failures, and I addressed those by making the memprof
runtime build also conditional on COMPILER_RT_BUILD_SANITIZERS
(3ed77ecd0a5d5e5c33770f0f9d3d75cf2f80c80b). However, this resulted in
another inconsistency with how the tests were set up that was hit by
Chromium:
  https://bugs.chromium.org/p/chromium/issues/detail?id=1142191

Undo the original bot fix and address this with a more comprehensive fix
that enables memprof to be built even when COMPILER_RT_BUILD_SANITIZERS
is disabled, by also building the necessary pieces under
COMPILER_RT_BUILD_MEMPROF.

Tested by configuring with a similar command as to what was used in the
failing Chromium configure. I reproduced the Chromium failure, as well
as the original bot failure I tried to fix in
3ed77ecd0a5d5e5c33770f0f9d3d75cf2f80c80b, with that fix reverted.
Confirmed it now works.

Differential Revision: https://reviews.llvm.org/D90190